Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plugin categories submenues #26095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ash-86
Copy link

@Ash-86 Ash-86 commented Jan 14, 2025

Since 4.0, plugins of the same category (that are different from built it ones) don't get their own submenu. This PR attempts to fix that.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Contributor

@Ash-86 To make the QA team's lives easier, could you provide a list of reproduction steps and perhaps some plugins that can be used for reproducing the problem? Thanks in advance!

@Ash-86
Copy link
Author

Ash-86 commented Jan 19, 2025

Sure!

  • Set the category of a plugin to one of the default categories. They would be correctly included in that category submenu.
  • Set the category to sometheng other than deafult values, MU ignores it and puts the plugin entries in the general Plugin Tab, without creating it's submenu.

I remember this issue coming up several times on the forum. Here are some plugins to test. I hope i was helpful enough.

Plugins with non default category, "editing-tools" and "Roll voicing":
https://github.com/Ash-86/Chord-Level-Filter
https://github.com/Ash-86/Roll-Voicing

plugins with default category, "composing-arranging-tools":
https://github.com/Ash-86/Move-Selection
https://github.com/Ash-86/Copy-Special

plugin without category:
https://github.com/Ash-86/Pitch-and-Rhythm-Transformer/tree/main/MU4.x

Allow submenues of plugin categories that are not built in.
@cbjeukendrup cbjeukendrup force-pushed the plugins-categories-subMenues-fix branch from b55d00e to 175bdb2 Compare February 24, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants